Skip to content

gh-140715: Improve class reference links on datetime.rst#123980

Merged
hugovk merged 13 commits intopython:mainfrom
uatach:audit-links
Mar 1, 2026
Merged

gh-140715: Improve class reference links on datetime.rst#123980
hugovk merged 13 commits intopython:mainfrom
uatach:audit-links

Conversation

@uatach
Copy link
Contributor

@uatach uatach commented Sep 11, 2024

Another pull request based on PR #21447, this one is focused on improving class reference links.


📚 Documentation preview 📚: https://cpython-previews--123980.org.readthedocs.build/

@uatach uatach requested a review from erlend-aasland October 28, 2024 21:33
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I compared the rendered preview with the existing docs, and there are still quite a few places where I think the link density is too high within a paragraph. I'll jot them down tomorrow or the day after.

@uatach
Copy link
Contributor Author

uatach commented Dec 2, 2024

I compared the rendered preview with the existing docs, and there are still quite a few places where I think the link density is too high within a paragraph. I'll jot them down tomorrow or the day after.

@erlend-aasland did you have a chance to look into this?

@hugovk hugovk changed the title gh-85453: Improve class reference links on datetime.rst gh-140715: Improve class reference links on datetime.rst Dec 22, 2025
@hugovk
Copy link
Member

hugovk commented Dec 22, 2025

Thanks for this PR, this is an improvement. If there's more suggestions, we can do that in a followup. But let's merge this as it's been open a while.

Whilst we're here, I'm going to push an update to put the headers in sentence case (see style guide) and will merge tomorrow if no objections.

@hugovk hugovk added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Dec 22, 2025
@StanFromIreland StanFromIreland self-requested a review as a code owner March 1, 2026 10:21
@hugovk hugovk merged commit 6c417e4 into python:main Mar 1, 2026
28 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Mar 1, 2026
@miss-islington-app
Copy link

Thanks @uatach for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @uatach and @hugovk, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 6c417e44c995eb57e8266e18eb8aeeb2ba0e61ac 3.14

@miss-islington-app
Copy link

Sorry, @uatach and @hugovk, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 6c417e44c995eb57e8266e18eb8aeeb2ba0e61ac 3.13

hugovk added a commit to hugovk/cpython that referenced this pull request Mar 1, 2026
…pythonGH-123980)

(cherry picked from commit 6c417e4)

Co-authored-by: edson duarte <eduarte.uatach@gmail.com>
Co-authored-by: Erlend E. Aasland <erlend@python.org>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Mar 1, 2026

GH-145388 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Mar 1, 2026
hugovk added a commit to hugovk/cpython that referenced this pull request Mar 1, 2026
…pythonGH-123980)

(cherry picked from commit 6c417e4)

Co-authored-by: edson duarte <eduarte.uatach@gmail.com>
Co-authored-by: Erlend E. Aasland <erlend@python.org>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Mar 1, 2026

GH-145389 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Mar 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants