gh-118948: add support for ISO 8601 basic format to datetime
#120553
+411
−116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nineteendo
reviewed
Jun 15, 2024
nineteendo
reviewed
Jun 15, 2024
Member
StanFromIreland
left a comment
StanFromIreland
left a comment
There was a problem hiding this comment.
It needs some polishing and simplification in my opinion, especially tests, but looks very good in general :-)
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
picnixz
commented
Mar 22, 2025
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
picnixz
commented
Mar 22, 2025
picnixz
commented
Mar 22, 2025
StanFromIreland
approved these changes
Mar 22, 2025
Member
StanFromIreland
left a comment
StanFromIreland
left a comment
There was a problem hiding this comment.
I guess we can leave refactoring for later. LGTM :-)
Member
Author
|
Oh great I messed up my merge commit (I was looking at my diff...) |
picnixz
force-pushed
the
basic-iso-date
branch
from
86e435a to
698fa16
Compare
Member
Author
|
@pganssle Do you mind having a look at this PR now that you're +0.5? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to
dateanddatetime,datetime.timealso supports ISO 8601 basic format (the rationale is to make it consistent).📚 Documentation preview 📚: https://cpython-previews--120553.org.readthedocs.build/