Skip to content

Add support for Python 3.13-3.14 and drop support EOL 3.7-3.9#53

Merged
A5rocks merged 9 commits intopython-trio:masterfrom
hugovk:add-3.13
Mar 5, 2026
Merged

Add support for Python 3.13-3.14 and drop support EOL 3.7-3.9#53
A5rocks merged 9 commits intopython-trio:masterfrom
hugovk:add-3.13

Conversation

@hugovk
Copy link
Contributor

@hugovk hugovk commented Feb 28, 2025

@hugovk hugovk changed the title Add support for Python 3.13 and drop support EOL 3.7-38 Add support for Python 3.13 and drop support EOL 3.7-3.8 Sep 14, 2025
@hugovk hugovk changed the title Add support for Python 3.13 and drop support EOL 3.7-3.8 Add support for Python 3.13-3.14 and drop support EOL 3.7-3.8 Sep 14, 2025
@hugovk
Copy link
Contributor Author

hugovk commented Sep 14, 2025

Updated to add support for Python 3.14.

@hugovk hugovk changed the title Add support for Python 3.13-3.14 and drop support EOL 3.7-3.8 Add support for Python 3.13-3.14 and drop support EOL 3.7-3.9 Oct 18, 2025
@hugovk
Copy link
Contributor Author

hugovk commented Oct 18, 2025

Updated to drop support for EOL Python 3.9.

@hugovk hugovk force-pushed the add-3.13 branch 2 times, most recently from 9f35be6 to 8ce278a Compare January 13, 2026 16:46
@cclauss cclauss requested a review from bowiechen March 5, 2026 14:17
version: 2

build:
os: ubuntu-22.04
Copy link
Contributor

@cclauss cclauss Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we revert this change and also the change on line 7 so that we can get this test to pass? It passes on:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! But also it looks like no-one is merging anything here, and I normally close year-old PRs.

Is it likely this might be merged, given also #54 and #55?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I closed #54 to deduplicate this effort.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately I didn't have this repo watched ^^

I'd personally prefer to merge #55 given someone else is reviewing it. I haven't actually looked at the contents of PRs to know if there's concrete differences though.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed this and approved.

@cclauss cclauss removed the request for review from bowiechen March 5, 2026 17:00
@cclauss
Copy link
Contributor

cclauss commented Mar 5, 2026

Git conflicts...

If you rebase and add https://github.com/re-actors/alls-green then @A5rocks can remove the Requirements tags and we can git this merged.

@hugovk
Copy link
Contributor Author

hugovk commented Mar 5, 2026

Git conflicts...

If you rebase

Rebased!

and add re-actors/alls-green

@cclauss Please could you send a PR to my branch with this?

@A5rocks
Copy link
Contributor

A5rocks commented Mar 5, 2026

Not a PR but see https://github.com/python-trio/trio/blob/main/.github/workflows/ci.yml#L475 for how Trio uses that

name: CI

on: [push, pull_request]
on: [push, pull_request, workflow_dispatch]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, why this change?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It adds the missing button to the UI to let you manually trigger a build from https://github.com/python-trio/sniffio/actions/workflows/ci.yml

It will look something like:

image

You don't need it very often, but when you do, it's annoying to if it's not been enabled yet!

@cclauss
Copy link
Contributor

cclauss commented Mar 5, 2026

Run re-actors/alls-green@release/v1
Run python -m normalize_needed_jobs_status \
# ✓ All of the required dependency jobs succeeded 🎉🎉🎉

📝 Job statuses:
📝 Windows → ✓ success [required to succeed]
📝 Ubuntu → ✓ success [required to succeed]
📝 macOS → ✓ success [required to succeed]
0s

@cclauss cclauss requested review from A5rocks and bowiechen March 5, 2026 20:36
Copy link
Contributor

@A5rocks A5rocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some formatting comments

A5rocks added 2 commits March 5, 2026 15:45
I meant to batch these changes together, oops...
@A5rocks A5rocks merged commit 95190ad into python-trio:master Mar 5, 2026
21 checks passed
@hugovk hugovk deleted the add-3.13 branch March 5, 2026 21:08
@hugovk
Copy link
Contributor Author

hugovk commented Mar 5, 2026

Thanks both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants