Fix tests in preparation for behavior change in modern Cython#10
Merged
rosjat merged 2 commits intopython-scsi:masterfrom Nov 10, 2025
Merged
Conversation
using latest version of precommit
691069c to
a7959df
Compare
Contributor
|
@Flameeyes can you review and merge on approval please |
Contributor
|
@Flameeyes i will merge this now since it simply bumps the precommit and changes a test case |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modern
cythonchanges howcpdef enums are exposed. Update the tests so that they will work with both old and new cython.Given
We used to be able to either use
iscsi.ISCSI_SESSION_NORMALoriscsi.iscsi_session_type.ISCSI_SESSION_NORMAL. With modern cython, only the latter works.From https://cython.readthedocs.io/en/latest/src/userguide/language_basics.html#structs-unions-enums
Verified the breakage and fix in a venv on Debian Trixie nightly, and on Bookworm.
The https://pypi.org/project/Cython/ shows