Default to using Python 3.14 for !eval#3406
Merged
Merged
Conversation
jb3
added
a: utility
This will allow all other utility files within the snekbox cog to access types such as `SupportedPythonVersions` without causing circular import issues.
jb3
force-pushed
the
jb3/eval-command-3.14
branch
from
a3b2b00 to
4ff670c
Compare
There was a problem hiding this comment.
Pull Request Overview
Updates the eval command to use Python 3.14 as the default version instead of 3.13, and removes the pre-release notice for Python 3.14 jobs. This change aligns with snekbox switching from Python 3.14.0rc1 to 3.14.0.
- Moved
SupportedPythonVersionsand related constants to a new dedicated constants module - Changed default Python version from "3.13" to the first available version (3.14) using
get_args() - Removed the pre-release notice for Python 3.14 in status messages
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
bot/exts/utils/snekbox/_eval.py |
Updates default version to use first available Python version and removes 3.14 pre-release notice |
bot/exts/utils/snekbox/_constants.py |
New module containing SupportedPythonVersions type and other constants |
bot/exts/utils/snekbox/_cog.py |
Refactored to import constants from new module instead of defining them locally |
bot/exts/utils/snekbox/__init__.py |
Updates imports to reflect the moved SupportedPythonVersions type |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ChrisLovering
approved these changes
Oct 9, 2025
ChrisLovering
left a comment
ChrisLovering
left a comment
Member
There was a problem hiding this comment.
Should we drop 3.13t for 3.14t now too?
Instead of using typing.get_args(...) and fetching the first value returned (which is mostly safe, but not guaranteed to be so), use a new constant DEFAULT_PYTHON_VERSION to control the current default Python executor when no explicit interpreter version is passed.
jb3
force-pushed
the
jb3/eval-command-3.14
branch
from
85dec81 to
92a0fb8
Compare
Removes the need to hardcode each specific "3.Xt" version we may support in future. Co-authored-by: ChrisJL <ChrisLovering@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
See python-discord/snekbox#246 for relevant snekbox changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the eval command to default to executing user code with snekbox's Python 3.14 binary.
See python-discord/snekbox#245 for the related snekbox change to switch from 3.14.0rc1 to 3.14.0.
The notice about 3.14 jobs being pre-release is also removed by this PR.