allow passing a custom ArqRedis class to create_pool#495
Open
jvllmr wants to merge 1 commit intopython-arq:mainfrom
Open
allow passing a custom ArqRedis class to create_pool#495jvllmr wants to merge 1 commit intopython-arq:mainfrom
ArqRedis class to create_pool#495jvllmr wants to merge 1 commit intopython-arq:mainfrom
Conversation
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #495 +/- ##
==========================================
- Coverage 96.27% 96.10% -0.17%
==========================================
Files 11 11
Lines 1074 1079 +5
Branches 209 190 -19
==========================================
+ Hits 1034 1037 +3
- Misses 19 21 +2
Partials 21 21
Continue to review full report in Codecov by Sentry.
|
f7be1f3 to
dcba348
Compare
dcba348 to
c1ce72c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would like to extend the functionality of the
ArqRedisin one of my projects, but I also want to use the original create_pool function. It would be great if thecreate_poolfunction would accept a custom class which extendsArqRedis