code: minor refactors and code improvements around exception formatting#14573
Merged
Conversation
Already inherited from `ExceptionRepr`.
Not needed (ignored) since Python 3.10, I was slightly confused by this: https://docs.python.org/3/library/traceback.html#traceback.format_exception_only
I think the code is clearer with the init is done in one shot.
"Formatted Excinfo" is a bit misleading, this class formats an ExceptionInfo, it isn't itself a formatted exception info.
They are not very helpful but just to give a brief description.
Member
Author
|
Thanks for the review @RonnyPfannschmidt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been reading this code when looking at exception group formatting, and made some tweaks. Please see the commits.