fixtures: deprecate FixtureDef.has_location and None global fixture visibility#14567
fixtures: deprecate FixtureDef.has_location and None global fixture visibility#14567bluetech wants to merge 3 commits into
FixtureDef.has_location and None global fixture visibility#14567Conversation
|
i wonder if this has actual external users and which those are to decide actual removal later |
41bc25f to
7186cd4
Compare
has_location was used to determine the fixture override order, pushing fixturedefs with no location to the front of the override chain. Now that the override order is determined by the fixtures' visibility in the collection tree, the attribute is no longer needed. Turn it into a property that emits a PytestRemovedIn10Warning, backed by the private _has_location attribute, and document the deprecation.
…ility instead of None Let's get rid of the `None` global visibility. Use `Session` which is functionality equivalent instead. - Allows us to remove an annoying special case from the fixture core. - Allows a cleaner public `register_fixture` interface (upcoming). There was previously a distinction between "has location" (e.g. conftest plugins) and "no location" (e.g. external plugins), but it's no longer needed after recent changes. Since initial conftest plugins are always registered after core & external plugins, the override chain order is maintained.
The nodeid-visibility/baseid deprecation previously allowed None (global) visibility. But this visibility is no longer needed, should use Session visibility instead. So let's include it in the deprecation as well, this way we can have a clean break in pytest 10.
b50559e to
547eb13
Compare
I looked at my pytest plugin corpus (checkouts of ~700 plugins). For For For Finally, for |
This PR is stacked on:
get_scope_packagewhen possible #14565The first commit deprecates
FixtureDef.has_location. With #14566 it is no longer needed, and use of it is probably wrong.The second commit removes internal use of
Noneglobal visibility, replaced bySessionvisibility.The third commit deprecates global
Nonevisibility (extends thenodeid/baseiddeprecation).With this (the non-deprecated parts of)
_register_fixtureare neat and clean and this readies us to expose apytest.register_fixture(next commit in the stack).