fix: catch KeyError when accessing __name__ in _idval_from_value (#14560)#14561
Open
NIK-TIGER-BILL wants to merge 2 commits into
Open
fix: catch KeyError when accessing __name__ in _idval_from_value (#14560)#14561NIK-TIGER-BILL wants to merge 2 commits into
NIK-TIGER-BILL wants to merge 2 commits into
Conversation
…est-dev#14560) Custom classes with a __getattr__ that raises KeyError instead of AttributeError would crash pytest during parameterized test id generation. We now catch both AttributeError and KeyError. Fixes pytest-dev#14560 Signed-off-by: NIK-TIGER-BILL <nik.tiger.bill@github.com>
psf-chronographer
Bot
added
the
bot:chronographer:provided
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #14560.
Custom classes with a
__getattr__that raisesKeyError(instead ofAttributeError) would crash pytest during parameterized test id generation. This PR catches bothAttributeErrorandKeyErrorwhen trying to access__name__.Checklist
closes #14560to the PR description and/or commits.changelogdirectory.AUTHORSin alphabetical order.