Add examples for GWLinearRegression and GWLogisticRegression#87
Add examples for GWLinearRegression and GWLogisticRegression#87aman-coder03 wants to merge 4 commits intopysal:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #87 +/- ##
==========================================
+ Coverage 91.36% 92.01% +0.65%
==========================================
Files 6 6
Lines 799 814 +15
==========================================
+ Hits 730 749 +19
+ Misses 69 65 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I was anticipating something else. This is mirroring what is already in the user guide, just reshuffled. I was more hoping for an example on how to use gwlearn on a real-world case, something like we have in momepy. This still uses the default example dataset and does not add anything on top of what the documentation already covers. |
|
Thank you for the feedback @martinfleis |
|
No. If you want to contribute an example I would expect it comes from you. It takes time to come up with a good example, I don't know what is going to work well. |
|
@martinfleis i have replaced the linear regression example with a real world case study using US state income data(1929-2009) investigating the income convergence hypothesis. I will work on coming up with a similarly meaningful real world case for the logistic regression example as well |
|
I explored the Tokyo mortality dataset from |
|
@martinfleis can you please have a look and suggest changes if needed? |
|
The fact that I haven't responded two days, which also happened to be a weekend made you think it is fine to remind me? |
|
you are right, I apologize. I should have waited longer before pinging |
Summary
Closes #85
This PR adds two new example notebooks to the User Guide demonstrating complete workflows for
GWLinearRegressionandGWLogisticRegression.Changes
docs/source/gw_linear_regression_example.ipynb- new example notebookdocs/source/gw_logistic_regression_example.ipynb- new example notebookdocs/source/index.md- added both notebooks to the User Guide toctreeWhat the examples cover
GWLinearRegression example:
libpysalus_income)local_coef_) mapped and interpreted by regionlocal_r2_) and residual (resid_) analysisGWLogisticRegression example:
prediction_rate_y_pooled_,pred_pooled_)local_metriclocal_coef_)