-
Notifications
You must be signed in to change notification settings - Fork 0
Change get_scope parameter type from FunctionType to object #186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
947bb77
Change get_scope parameter type from FunctionType to object
samwaseda 66ff2ae
Potential fix for pull request finding
samwaseda e590d72
Initial plan
Copilot 08012f7
Handle None from inspect.getmodule() in get_scope with fallback and c…
Copilot 539fe52
Remove accidentally committed _version.py build artifact and add to .…
Copilot 1f8b6e4
Apply black formatting to changed files
Copilot 1f66017
Update .gitignore
samwaseda 62fa0e4
Merge pull request #187 from pyiron/copilot/sub-pr-186
samwaseda 96a2dd6
Initial plan
Copilot 5dc7500
Add test to cover sys.modules.get fallback in get_scope (line 53)
Copilot 0c38bda
Remove accidentally committed _version.py and add to .gitignore
Copilot bcffb5c
Apply suggestion from @samwaseda
samwaseda 092f66c
Merge pull request #188 from pyiron/copilot/sub-pr-186
samwaseda e7bbd53
Initial plan
Copilot 488fd60
Add rubber-meets-the-road tests for get_scope with various callable t…
Copilot 1514891
Remove _version.py build artifact and add to .gitignore
Copilot 5ec4ac0
Fix test_lambda assertions to be directly about the scoped object
Copilot f9e61bf
Update tests/unit/models/parsers/test_object_scope.py
samwaseda 3c260aa
Merge pull request #189 from pyiron/copilot/sub-pr-186
samwaseda File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,3 +11,4 @@ apidoc/ | |
| .ipynb_checkpoints/ | ||
| test_times.dat | ||
| core.* | ||
| flowrep/_version.py | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov is showing that this line is not covered. I'd like to get it fully covered, but I'm a little confused because it looks to me like
test_none_module_fallback_via_dunder_moduleshould be hitting this?