Conversation
|
@liamhuber I started looking into the possibility of including variables as well. Frankly I'm also not really convinced but I still would like to explore the possibility |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #164 +/- ##
==========================================
- Coverage 97.96% 97.75% -0.21%
==========================================
Files 34 34
Lines 2259 2275 +16
==========================================
+ Hits 2213 2224 +11
- Misses 46 51 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I just had a discussion with @XzzX and we think we can keep the current implementation is maybe not quite as useless as I had imagined, because with this implementation it is now possible to throw an error as soon as an external variable is used. |
Failing cleanly is infinitely better than looking like everything is well-provenanced when it isn't. However, I still think that restricting "ok locally defined stuff" to mean "don't use any symbols outside your function definition" is going to turn out to be a more annoying, more restrictive, more-work solution than telling people "you'll have to use well-versioned code to contribute to the KG". As an intermediate step towards catching and leveraging these external symbols, this still seems like solid progress though. |
Following the effort in #155, I started trying to parse variables as well. Edits will follow....