Merged
Conversation
of the WorkflowParser, instead of kicking it around Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
Instead of the runtime method binding. The subclass doesn't strictly satisfy LSP, but we use it in this place and this place only so I can live with it. I massaged the generic visit "don't recognize this" error message a little. Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
The callers don't actually use all those internal visit nodes, so just specify the actual interface Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #157 +/- ##
==========================================
- Coverage 98.94% 98.94% -0.01%
==========================================
Files 27 27
Lines 1903 1901 -2
==========================================
- Hits 1883 1881 -2
Misses 20 20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
Member
|
FYI, I was also only vaguely aware of |
samwaseda
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@samwaseda introduced me to it in #155. IMO this makes the model parsers easier to read and more ast-idiomatic. Should make it slightly easier to extend the parser to accommodate even more python syntax in the future.