Conversation
Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
And return a map between the version info and the usages. Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## crawler #156 +/- ##
===========================================
- Coverage 98.82% 98.78% -0.04%
===========================================
Files 28 28
Lines 1954 1976 +22
===========================================
+ Hits 1931 1952 +21
- Misses 23 24 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Yep it looks really nice to me. Good that you took a look at it because I was not fully aware of |
samwaseda
left a comment
There was a problem hiding this comment.
I merge this one to crawler, because now that I removed my original functions it makes little sense to keep two PRs open
|
Note: I just realized that I had failed to push my last changes (in which I erased |
@samwaseda, I replaced the
object_scope-replacable parts, and then took a crack at writing a crawler that returnsdict[versions.VersionInfo, list[Callable]], which is the sort of symmetry I had in mind, and a splitter to get back your versioned/unversioned groupings. Claude did the tests, but I read them and they look good to me. Does this still meet your needs?