Merged
Conversation
Member
Author
|
I'm so done with these loops ... |
Member
Author
|
Ref pygfx/wgpu-py#780, don't need the idea of a running loop anymore. So this now boils down to dropping sniffio (using async_gen_hooks instead) and some tweaks to improve the definition of when a loop is running. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rendercanvas.get_running_loop()that returns the running loop for the current thread.asyncgen_hooksto detect the current framework.I ran some benchmarks
This shows that using
asyncgen_hooksis faster. It's speed is also more stable than sniffio, which speed depends on the order it tries different libs.