Improve performance of arithmetic on MultiVector pairs#283
Merged
eric-wieser merged 1 commit intopygae:masterfrom Mar 12, 2020
Merged
Improve performance of arithmetic on MultiVector pairs#283eric-wieser merged 1 commit intopygae:masterfrom
eric-wieser merged 1 commit intopygae:masterfrom
Conversation
The previous code was optimized for `MultiVector <op> something_else`, incurring an expensive `isinstance(other, numbers.Number)` check. This changes it to check `isinstance(other, MultiVector)` first, which is the case that is going to be most frequent.
Codecov Report
@@ Coverage Diff @@
## master #283 +/- ##
==========================================
+ Coverage 63.06% 63.14% +0.08%
==========================================
Files 50 50
Lines 7294 7294
Branches 1033 1033
==========================================
+ Hits 4600 4606 +6
+ Misses 2545 2540 -5
+ Partials 149 148 -1
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous code was optimized for
MultiVector <op> something_else, incurring an expensiveisinstance(other, numbers.Number)check.This changes it to check
isinstance(other, MultiVector)first, which is the case that is going to be most frequent.Extracted from #280, since it's a tiny patch