Cleanup and write tests for clifford.cga#183
Merged
eric-wieser merged 3 commits intopygae:masterfrom Oct 28, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #183 +/- ##
========================================
+ Coverage 52.17% 55% +2.82%
========================================
Files 41 42 +1
Lines 6355 6419 +64
Branches 987 989 +2
========================================
+ Hits 3316 3531 +215
+ Misses 2913 2743 -170
- Partials 126 145 +19
Continue to review full report at Codecov.
|
Member
Author
|
Travis passes, coverage increased, and there are open issues for all the xfailing tests. If the tests seem like nonsense, we can fix them in a follow-up / discuss in the open bugs |
Member
|
nice job on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This doesn't attempt to fix any bugs, but at least converts unknown bugs into known bugs. The bugs this exposed are: