Make benchmark arguments more flexible#4862
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4862 +/- ##
=======================================
Coverage 82.71% 82.71%
=======================================
Files 330 330
Lines 17887 17887
=======================================
Hits 14795 14795
Misses 3092 3092 Continue to review full report at Codecov.
|
|
Can you clarify? Wouldn't it be easier to just pass in a list of lists? No strong opinion though :) |
Hmm, maybe I misunderstood how it was meant to be used before. Using argparse I couldn't find an obvious way to pass a list of lists, except using the approach given in this MR. |
|
Curious if anyone else has opinions on this? @mszarma you were the github suggested reviewer |
|
I think your idea makes sense, let me integrate your change. Thanks! |
|
Thanks for the suggestion @mszarma - have modified this PR |
17a5f88 to
84ab29b
Compare
This is currently WIP - I needed this locally to make it possible to modify these arguments in the benchmarks. If people like the suggested format I will apply this to all benchmarks.
Note because some argument are list and some are lists of lists, you would need to do
and