Skip to content

Squeeze arrays before converting to scalar (fix numpy 2.4.0)#259

Merged
f-brinkmann merged 2 commits intodevelopfrom
fix/numpy-2.4.0
Jan 5, 2026
Merged

Squeeze arrays before converting to scalar (fix numpy 2.4.0)#259
f-brinkmann merged 2 commits intodevelopfrom
fix/numpy-2.4.0

Conversation

@hoyer-a
Copy link
Copy Markdown
Member

@hoyer-a hoyer-a commented Dec 23, 2025

Which issue(s) are closed by this pull request?

Closes #258

Changes proposed in this pull request:

  • Conversion of an array with ndim > 0 to a scalar was deprecated in NumPy 1.25.
  • Squeeze arrays before converting to scalar

Note

Fixed on dev, since tests on main are not affected by the changes.

@hoyer-a hoyer-a added this to the v1.0.0 milestone Dec 23, 2025
@hoyer-a hoyer-a added the bug Something isn't working label Dec 23, 2025
@hoyer-a hoyer-a moved this from Backlog to Require review in Weekly Planning Dec 23, 2025
@github-project-automation github-project-automation Bot moved this from Require review to Reviewer Approved in Weekly Planning Dec 24, 2025
@hoyer-a hoyer-a moved this from Reviewer Approved to Require review in Weekly Planning Dec 24, 2025
Copy link
Copy Markdown
Member

@ahms5 ahms5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think squeeze is very elegenat compared to our previous solution with just accessing the first item in the array.

@github-project-automation github-project-automation Bot moved this from Require review to Reviewer Approved in Weekly Planning Dec 29, 2025
@f-brinkmann f-brinkmann merged commit 52f6357 into develop Jan 5, 2026
10 of 11 checks passed
@github-project-automation github-project-automation Bot moved this from Reviewer Approved to Done in Weekly Planning Jan 5, 2026
@f-brinkmann f-brinkmann deleted the fix/numpy-2.4.0 branch January 5, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working external deprecation

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants