Plots/Add style parameter to plot module #257
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
hoyer-a
requested review from
a team,
ahms5,
f-brinkmann,
mberz,
sikersten and
tluebeck
f-brinkmann
approved these changes
Dec 22, 2025
Member
f-brinkmann
left a comment
f-brinkmann
left a comment
There was a problem hiding this comment.
Thanks. Looks good to me. This also improved the look of the example plots. For balloon and balloon_wireframe the axes are still clipping the colorbar, but I would leave this as is for now.
github-project-automation
bot
moved this from Require review
to Reviewer Approved
in Weekly Planning
ahms5
reviewed
Dec 29, 2025
Member
ahms5
left a comment
ahms5
left a comment
There was a problem hiding this comment.
Thanks, looks great, I wonder why if the defult plots have noch changed due to the new default for style.
Member
Author
|
I only generated baseline plots for the new style parameter. I would update #242 once this is merged |
ahms5
approved these changes
Dec 31, 2025
Member
|
@mberz do you want to review as well? We could merge otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges into #222
Which issue(s) are closed by this pull request?
Closes #183
Changes proposed in this pull request:
Note
Tests fail because of a new numpy release, see #258