Class containing the spherical harmonic definition #173
Conversation
The default for the Condon-Shortley phase depends on the basis type
f-brinkmann
left a comment
f-brinkmann
left a comment
There was a problem hiding this comment.
Thanks for the effort. This will be very nice to have. Looks like many comments, but they are all rather small and and in some cases repeating.
|
|
||
|
|
||
| class SphericalHarmonics: | ||
| class SphericalHarmonicDefinition: |
There was a problem hiding this comment.
For discussion: Should this be public or private? From the top of my head, I did not see any use for it if its not connected to any data (SH basis or Ambisonics signal).
There was a problem hiding this comment.
Public, since it can for example be used to create transforms, such as rotations/translations
There was a problem hiding this comment.
Not sure, would depend on how these will be implemented. The current draft of the SHT would not need it, I think. We could also keep it private until we need it to be public.
There was a problem hiding this comment.
SHT woulnt need it, but SphericalHarmonics and SpericalHarmonicsSignal, SpericalHarmonicsTimeData and SpericalHarmonicsFrequencyData would need it. in this way they save a lot of duplicated code.
There was a problem hiding this comment.
Yes, of course - I was only wondering about public vs. private. Public is probably not required for those examples.
There was a problem hiding this comment.
I wrote translations/rotations, not SHT ;)
| Attributes | ||
| ---------- | ||
| condon_shortley : bool |
There was a problem hiding this comment.
Does not document condon_shortley = 'auto'. Maybe not needed it class would be private, but nice to have in any case.
|
For completeness, this somehow PR relies on #151. Or should we add the classes to the docs here? |
|
We discussed that it would be good to add |
|
I'm currently waiting for #172 to be ready and merged to continue working on this PR. |
|
it is merged now, please rerequest review if its ready |
|
superseded by #205 |
This additional class could be used to provide the definition of the sperical harmonics to other classes.
The new class already serves as base class for the
SphericalHarmonicsclass.Requires #172
Todo: