Move SH class to sphary.classes #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xefonon
approved these changes
Jun 16, 2025
Member
xefonon
left a comment
xefonon
left a comment
There was a problem hiding this comment.
Thanks, it looks fine to me. :)
github-project-automation
bot
moved this from Require review
to Reviewer Approved
in Weekly Planning
ahms5
reviewed
Jun 16, 2025
Member
ahms5
left a comment
ahms5
left a comment
There was a problem hiding this comment.
What about moving SphericalHarmonicsSignal to sh.py as well, especially if they are on the same documentation page?
Member
Author
|
ok - merging this and @tluebeck can maybe move the SH Signal class to the same file in a separate pull. After this we can continue updating the docs, where Tim already opened a pull :) |
github-project-automation
bot
moved this from Reviewer Approved
to Done
in Weekly Planning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
required for #151
--author=xefononso I hope the original authorship is maintained