revise PR template on Github #91
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ahms5
commented
Oct 27, 2025
ahms5
commented
- collected drafts from others
ahms5
commented
Oct 27, 2025
Comment on lines
+17
to
+32
| <!-- ---------------------------------------------------------------- | ||
| MAKE SURE YOUR PR GETS THE ATTENTION IT DESERVES! | ||
| ---------------------------------------------------------------- | ||
| * FORMAT IT RIGHT: | ||
| https://www.numpy.org/devdocs/dev/development_workflow.html#writing-the-commit-message | ||
| * IF IT'S A NEW FEATURE OR API CHANGE, TEST THE WATERS: | ||
| https://www.numpy.org/devdocs/dev/development_workflow.html#get-the-mailing-list-s-opinion | ||
| * HIT ALL THE GUIDELINES: | ||
| https://numpy.org/devdocs/dev/index.html#guidelines | ||
| * WHAT TO DO IF WE HAVEN'T GOTTEN BACK TO YOU: | ||
| https://www.numpy.org/devdocs/dev/development_workflow.html#getting-your-pr-reviewed | ||
| --> |
Member
Author
There was a problem hiding this comment.
this is from nump, it is basically a commented markdown and will be hidden in the pr later
Comment on lines
+13
to
+15
| - [ ] tests added/passed | ||
| - [ ] add an entry to the [changelog](../CHANGELOG.md) | ||
|
|
Member
Author
There was a problem hiding this comment.
in the pyopensci template was just a 4 point checklist, I tried to adapt it to our previous template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.