Skip to content

fix: defer pd.to_datetime() in test parametrize to avoid nightly segfault #11407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
C1-BA-B1-F3 wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −5
Open

fix: defer pd.to_datetime() in test parametrize to avoid nightly segfault #11407

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions xarray/tests/test_coding_times.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -538,20 +538,21 @@ def test_infer_datetime_units(freq, units) -> None:


@pytest.mark.parametrize(
["dates", "expected"],
["date_strings", "expected"],
[
(
pd.to_datetime(["1900-01-01", "1900-01-02", "NaT"], unit="ns"),
["1900-01-01", "1900-01-02", "NaT"],
"days since 1900-01-01 00:00:00",
),
(
pd.to_datetime(["NaT", "1900-01-01"], unit="ns"),
["NaT", "1900-01-01"],
"days since 1900-01-01 00:00:00",
),
(pd.to_datetime(["NaT"], unit="ns"), "days since 1970-01-01 00:00:00"),
(["NaT"], "days since 1970-01-01 00:00:00"),
],
)
def test_infer_datetime_units_with_NaT(dates, expected) -> None:
def test_infer_datetime_units_with_NaT(date_strings, expected) -> None:
dates = pd.to_datetime(date_strings, unit="ns")
assert expected == infer_datetime_units(dates)


Expand Down
Loading