-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Pass container_id back to Anthropic API
#3637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4cc56e5 to
b713ad3
Compare
Contributor
Author
|
@DouweM for review whenever you have time |
DouweM
requested changes
Dec 4, 2025
Contributor
Author
|
@DouweM updated |
DouweM
requested changes
Dec 9, 2025
| self._usage = _map_usage(event, self._provider_name, self._provider_url, self._model_name, self._usage) | ||
| if raw_finish_reason := event.delta.stop_reason: # pragma: no branch | ||
| self.provider_details = {'finish_reason': raw_finish_reason} | ||
| self.provider_details = {**(self.provider_details or {}), 'finish_reason': raw_finish_reason} |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the 2-line way we do it on line 1158 slightly better
| By default, if previous messages contain a container_id (from a prior response), | ||
| it will be reused automatically. | ||
| Set to `False` to force a fresh container (ignore any container_id from history). |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| Set to `False` to force a fresh container (ignore any container_id from history). | |
| Set to `False` to force a fresh container (ignore any `container_id` from history). |
1c2c128 to
b3f0633
Compare
Contributor
Author
|
@DouweM updated |
b3f0633 to
4ba1ea8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves containerid part of #3365.