Add --host argument for Streamable HTTP mode
#27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DouweM
requested changes
Nov 21, 2025
mcp_run_python/main.py
Outdated
| http_host: str | None = None, | ||
| dependencies: list[str] | None = None, | ||
| return_mode: Literal['json', 'xml'] = 'xml', | ||
| return_mode: Literal["json", "xml"] = "xml", |
Contributor
There was a problem hiding this comment.
Can you please revert the changes to quotes?
DouweM
requested changes
Nov 25, 2025
mcp_run_python/_cli.py
Outdated
| formatter_class=argparse.RawTextHelpFormatter, | ||
| ) | ||
|
|
||
| parser.add_argument('--host', type=str, help='Host to bind the HTTP server to (default: 127.0.0.1). Use 0.0.0.0 for Docker.') |
Contributor
There was a problem hiding this comment.
This implies a bit too strongly that it's Docker-specific; what do you think about "Use 0.0.0.0 to bind to all interfaces, e.g. when using Docker"
mcp_run_python/deno/src/main.ts
Outdated
| if (args[0] === 'stdio') { | ||
| await runStdio(deps, flags['return-mode']) | ||
| return | ||
| await runStdio(deps, flags['return-mode']); |
Contributor
There was a problem hiding this comment.
We've got a bunch more linter edits here, including the import sorting up top. can you please revert that so the PR only has the necessary changes?
DouweM
reviewed
Nov 26, 2025
mcp_run_python/main.py
Outdated
| allow_networking: bool = True, | ||
| ) -> list[str]: | ||
| args = ['run'] | ||
| args = ["run"] |
Contributor
There was a problem hiding this comment.
All of these edits should really not be necessary, can you please make the diff as small as possible?
DouweM
reviewed
Nov 28, 2025
DouweM
changed the title
--host argument for Streamable HTTP mode
auto-merge was automatically disabled
December 4, 2025 03:34
Head branch was pushed to by a user without write access
Contributor
|
@sandsc Please have a look at the linter check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add --host parameter for streamable-http server to support host mcp-run-python in docker.