fix: review's api #1255
Closed
fix: review's api #1255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1255 +/- ##
==========================================
+ Coverage 74.59% 74.60% +0.01%
==========================================
Files 84 84
Lines 3184 3186 +2
==========================================
+ Hits 2375 2377 +2
Misses 809 809 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mattwang44
reviewed
Jul 27, 2025
| reviewer.groups.add(group) | ||
|
|
||
| api_client.force_authenticate(user=user) | ||
| api_client.force_authenticate(user=auth_user) |
Member
There was a problem hiding this comment.
#1247 (comment)
why does it need force_authenticate()?
Suggested change
| api_client.force_authenticate(user=auth_user) |
| if not role or role != "Reviewer": | ||
| return JsonResponse({'detail': 'role is not given or invalid.'}, status=400) | ||
| qs = User.objects.filter(is_active=True,verified=True, groups__name= "Reviewer") | ||
| qs = User.objects.get_valid_users_by_role(role).order_by('speaker_name') |
Collaborator
Author
|
@mattwang44 想請matt 大大幫我看一下>< |
mattwang44
reviewed
Aug 8, 2025
|
|
||
| - name: Set up Python dependencies | ||
| run: | | ||
| poetry env use python |
mattwang44
reviewed
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Thanks for sending a pull request! Please fill in the following content to let us know better about this change.
Please put an
xin the box that appliesDescription