Conversation
Merged
Collaborator
|
I just added a temporary example to illustrate how to perform an L2 projection on a FEM space, with basic manipulations and visualizations in 2D. At this stage this example is a work-in-progress, hopefully useful to decide which FEM functionalities should be exposed to the users (and possibly identify issues with the current api) |
0329a77 to
c783976
Compare
Collaborator
|
I think the notebook on FEM + L2 projection is good now (for review), I also mentioned the (H1) conforming projection. I can try to add another one with geometric projections or with "conga-type" Poisson solve, but I'm not sure this is really needed for the 1st release |
campospinto
reviewed
Dec 11, 2025
campospinto
reviewed
Dec 12, 2025
campospinto
reviewed
Dec 12, 2025
campospinto
reviewed
Dec 12, 2025
campospinto
reviewed
Dec 12, 2025
yguclu
requested changes
Dec 13, 2025
FrederikSchnack
commented
Dec 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Team, this PR fixes #170 .
I think the PR is in a good state for a review, the machinery seems to work quite well and the generated documentation looks nice. We can add more notebooks and examples over time.
New Examples
As discussed in the meeting, we proposed the following examples presented as jupyter notebooks:
[ ] FEM example: geometric projection (Martin)examples/vector_potential_3d.pyto a notebookNote: the geometric projections will be illustrated in a later PR, together with a discussion on the geometric nature of the (de Rham) conforming projections.
We can discuss these examples contents and allocation below.
Other todos:
psydac/feec/multipatch/examplestoexamples/feecand remove thepsydac/feec/multipatchfolder altogetherexamples/old_examplesperformancetoexamples/performanceexamples/?Getting the notebooks into the documentation
nb-cleanas a requirement similarly to inIGA-Python(and maybe also run it with the CI).examples.rsttoc.Testing the notebooks
The notebooks get run by the documentation CI, so any errors lead to a failing build of the documentation.

We can additionally employ
ipytestto check for explicit asserts (e.g. convergence errors) for example. I implemented this in thePoisson_non_periodic.ipynbnotebook.This is what a failing test looks like:
If the tests are passing, they are also written in the documentation, which looks like this:

Adding examples
You can try to keep a similar structure to the current notebooks in
examples/notebooks. Before commiting new notebooks, please runTo see the generated documentation download the artifact from the docs CI summary and open it in your browser locally.