Open
Conversation
|
|
vimzoomer
changed the title
vimzoomer
force-pushed
the
fix/infinite-recursion
branch
from
9b8966a to
e66f52b
Compare
- Remove CasbinAdapterConfig initialization in ready - Fix infinite recursion in __getattribute__ - Prevent test runner crash in testing environment
vimzoomer
force-pushed
the
fix/infinite-recursion
branch
from
e66f52b to
fa53bcf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I have two fixes for the adapter:
readyis discouraged by Django, sinceProxyEnforcerlazy-initializes Casbin anyway, initialization should be removed fromCasbinAdapterConfig.__getattribute__(self, name)caused byself.db_alias. Also, Ifenforceris imported in testing environment it breaks Django's test runner which calls__class__on every imported module during test discovery.