Add `PYBIND11_SIMPLE_GIL_MANAGEMENT` option (cmake, C++ define)#4216

Merged

rwgk merged 34 commits intopybind:masterfrom

Chekov2k:pypy_gil

Oct 30, 2022

Commits on Oct 30, 2022

Add option to force the use of the PYPY GIL scoped acquire/release logic to support nested gil access, see https://github.com/pybind/pybind11/issues/1276 and https://github.com/pytorch/pytorch/issu…

SeeChange-CI
authored and
rwgk
committed
Apply suggestions from code review

henryiii
authored and
rwgk
committed
Update CMakeLists.txt

henryiii
authored and
rwgk
committed
docs: update upgrade guide

henryiii
authored and
rwgk
committed
Update docs/upgrade.rst

henryiii
authored and
rwgk
committed
All bells & whistles.
rwgk
committed
Add Reminder to common.h, so that we will not forget to purge `!WITH_THREAD` branches when dropping Python 3.6
rwgk
committed
New sentence instead of semicolon.
rwgk
committed
Temporarily pull in snapshot of PR #4246
rwgk
committed
Add `test_release_acquire`
rwgk
committed
Add more unit tests for nested gil locking

SeeChange-CI
authored and
rwgk
committed
Add test_report_builtins_internals_keys
rwgk
committed
Very minor enhancement: sort list only after filtering.
rwgk
committed
Revert change in docs/upgrade.rst
rwgk
committed
Add test_multi_acquire_release_cross_module, while also forcing unique PYBIND11_INTERNALS_VERSION for cross_module_gil_utils.cpp
rwgk
committed
Hopefully fix apparently new ICC error.
rwgk
committed
clang-tidy fixes
rwgk
committed
Workaround for PYPY WIN exitcode None
rwgk
committed
Revert "Temporarily pull in snapshot of PR #4246"
rwgk
committed
Another workaround for PYPY WIN exitcode None
rwgk
committed
Clean up how the tests are run "run in process" Part 1: uniformity
rwgk
committed
Clean up how the tests are run "run in process" Part 2: use `@pytest.mark.parametrize` and clean up the naming.
rwgk
committed
Skip some tests `#if defined(THREAD_SANITIZER)` (tested with TSAN using the Google-internal toolchain).
rwgk
committed
Run all tests again but ignore ThreadSanitizer exitcode 66 (this is less likely to mask unrelated ThreadSanitizer issues in the future).
rwgk
committed
bug fix: missing common.h include before using `PYBIND11_SIMPLE_GIL_MANAGEMENT`
rwgk
committed
if process.exitcode is None: assert t_delta > 9.9
rwgk
committed
More sophisiticated `_run_in_process()` implementation, clearly reporting `DEADLOCK`, additionally exercised via added `intentional_deadlock()`
rwgk
committed
Wrap m.intentional_deadlock in a Python function, for `ForkingPickler` compatibility.
rwgk
committed
Add link to potential solution for WOULD-BE-NICE-TO-HAVE feature.
rwgk
committed
Add `SKIP_IF_DEADLOCK = True` option, to not pollute the CI results with expected `DEADLOCK` failures while we figure out what to do about them.
rwgk
committed
Add COPY-PASTE-THIS: gdb ... command (to be used for debugging the detected deadlock)
rwgk
committed
style: pre-commit fixes
pre-commit-ci[bot]
committed
Do better than automatic pre-commit fixes.
rwgk
committed
Add `PYBIND11_SIMPLE_GIL_MANAGEMENT` to `pytest_report_header()` (so that we can easily know when harvesting deadlock information from the CI logs).
rwgk
committed