Rename optional-dependencies to dependency-groups#5328
Closed
monish-instinct wants to merge 1 commit intopybamm-team:mainfrom
Closed
Rename optional-dependencies to dependency-groups#5328monish-instinct wants to merge 1 commit intopybamm-team:mainfrom
monish-instinct wants to merge 1 commit intopybamm-team:mainfrom
Conversation
Migrates from [project.optional-dependencies] to the modern [dependency-groups] format as specified in PEP 735. Fixes pybamm-team#5327
Saransh-cpp
reviewed
Dec 28, 2025
Member
Saransh-cpp
left a comment
Saransh-cpp
left a comment
There was a problem hiding this comment.
Thanks, @monish-instinct! Feel free to mark it as review or ping me if you need any help on this.
Member
|
It looks like this is inactive and will get superseded by #5368. Thanks for your intent to contribute @monish-instinct, and sorry if this fell through the cracks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates from [project.optional-dependencies] to the modern [dependency-groups] format as specified in PEP 735.
Fixes #5327
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Fixes # (issue)
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)
Important checks:
Please confirm the following before marking the PR as ready for review:
nox -s pre-commitnox -s testsnox -s doctests