Skip to content

feat: downsample oversized textures#260

Merged
tlambert03 merged 3 commits intopyapp-kit:mainfrom
tlambert03:downsample-large-3d
Mar 10, 2026
Merged

feat: downsample oversized textures#260
tlambert03 merged 3 commits intopyapp-kit:mainfrom
tlambert03:downsample-large-3d

Conversation

@tlambert03
Copy link
Member

fixes #259 for both vispy and pygfx. If the requested data is larger than the GPU allows, we downsample with a strided view.

@codecov
Copy link

codecov bot commented Mar 10, 2026

Codecov Report

❌ Patch coverage is 91.30435% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.76%. Comparing base (7b56e80) to head (ec8bb85).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ndv/views/_pygfx/_array_canvas.py 88.00% 3 Missing ⚠️
src/ndv/views/_vispy/_array_canvas.py 84.61% 2 Missing ⚠️
src/ndv/views/_vispy/_util.py 96.15% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #260      +/-   ##
==========================================
+ Coverage   86.65%   86.76%   +0.11%     
==========================================
  Files          48       50       +2     
  Lines        5687     5742      +55     
==========================================
+ Hits         4928     4982      +54     
- Misses        759      760       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tlambert03 tlambert03 merged commit 9ae382d into pyapp-kit:main Mar 10, 2026
65 checks passed
@tlambert03 tlambert03 deleted the downsample-large-3d branch March 10, 2026 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vispy Error: Cannot render larger 3D stack while smaller work fine

1 participant