Closed
Conversation
Collaborator
|
Yeah, I think these are all fine. Good to pin pygfx + friends for now. Especially love getting rid of the lockfile! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #234 +/- ##
==========================================
- Coverage 85.98% 85.14% -0.85%
==========================================
Files 46 46
Lines 5224 5229 +5
==========================================
- Hits 4492 4452 -40
- Misses 732 777 +45 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
thanks. also dropping python 3.9, which triggered a lot of autoformat changes |
…ize handling in tests
Member
Author
|
closed by #239 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this fixes some hard errors I'm getting on a recent resync (our lockfile was preventing it from showing... but since this is a library not an app, that lockfile doesn't protect end users). This PR
cc @gselzer ... you ok with these changes?
edit: this PR morphed. #235 is doing most of the change, now this is just here to try to update pygfx/rendercanvas/wgpu... but that turned into a bigger issue.