Skip to content

fix: update pygfx pinnings#234

Closed
tlambert03 wants to merge 10 commits intopyapp-kit:mainfrom
tlambert03:fix-pygfx
Closed

fix: update pygfx pinnings#234
tlambert03 wants to merge 10 commits intopyapp-kit:mainfrom
tlambert03:fix-pygfx

Conversation

@tlambert03
Copy link
Member

@tlambert03 tlambert03 commented Mar 4, 2026

this fixes some hard errors I'm getting on a recent resync (our lockfile was preventing it from showing... but since this is a library not an app, that lockfile doesn't protect end users). This PR

  • removes the lockfile
  • fixes the pyfgx errors
  • specifically allows rendercanvas to leak widgets (since something has changed and they now seem to have an internal strong reference that prevents cleanup)
  • pins pygfx/wgpu/rendercanvas, since they still change relatively often as they develop.

cc @gselzer ... you ok with these changes?


edit: this PR morphed. #235 is doing most of the change, now this is just here to try to update pygfx/rendercanvas/wgpu... but that turned into a bigger issue.

@tlambert03 tlambert03 marked this pull request as ready for review March 4, 2026 20:56
@gselzer
Copy link
Collaborator

gselzer commented Mar 4, 2026

Yeah, I think these are all fine. Good to pin pygfx + friends for now. Especially love getting rid of the lockfile!

@codecov
Copy link

codecov bot commented Mar 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.14%. Comparing base (50ce7b5) to head (de5e767).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #234      +/-   ##
==========================================
- Coverage   85.98%   85.14%   -0.85%     
==========================================
  Files          46       46              
  Lines        5224     5229       +5     
==========================================
- Hits         4492     4452      -40     
- Misses        732      777      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tlambert03 tlambert03 changed the title fix: fix pygfx changes and hard pin fix: fix pygfx changes and hard pin, drop py3.9 Mar 4, 2026
@tlambert03
Copy link
Member Author

thanks. also dropping python 3.9, which triggered a lot of autoformat changes

@tlambert03 tlambert03 changed the title fix: fix pygfx changes and hard pin, drop py3.9 fix: update pygfx pinnings Mar 4, 2026
@tlambert03
Copy link
Member Author

closed by #239

@tlambert03 tlambert03 closed this Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants