fix the remaining issues with the tests#524
Open
mats-knmi wants to merge 10 commits intoxarray/mainfrom
Open
Conversation
mats-knmi
force-pushed
the
xarray/fix-loose-ends
branch
from
15a70ff to
df21567
Compare
sidekock
reviewed
Sep 23, 2025
Contributor
sidekock
left a comment
sidekock
left a comment
There was a problem hiding this comment.
Hi Mats,
I wrote some follow ups, no glaring issues but just some things I wanted to double check with you
Contributor
|
Seems good to me. I think we can go ahead an merge with xarray/main |
Contributor
Author
|
@larsbonnefoy I have now merged the other PR. So you can take a look at this one if you still want to. @sidekock has already reviewed this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I removed the importer decorator as that only caused confusion most of the time, while it didn't really add anything. Also some tests failed again because of changes I made in the blending branch. This branch is based on the blending branch so it should be reviewed after #522 is merged