Added missing xdg-open dependencies.#26
Open
TravisDart wants to merge 1 commit intopwnall:masterfrom
TravisDart:master
Open
Added missing xdg-open dependencies.#26TravisDart wants to merge 1 commit intopwnall:masterfrom TravisDart:master
TravisDart wants to merge 1 commit intopwnall:masterfrom
TravisDart:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xdg-open calls xdg-mime in two places (line 584 and line 601), but the xdg-mime dependency is missing. This pull request adds xdg-mime and the utils file it depends on.
The only tricky part is that there is no reliable way to reference another shell script. So, I changed the JavaScript a bit so the location of the shell script is passed in as an environment variable.
I came across this problem while trying to run grunt-contrib-watch on Nitrous.io.