Split of combiner3d and instance_combiner3d into AC/DC specific tags #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Split of instance_combiner3d into instance_combiner_ac3d and instance_combiner_dc3d - Adjusted schematron rules - Added schematron rule to reject any tag not defined in PVC 2.0 schema - Adjusted example file Closes #49
cwhanse
approved these changes
Dec 11, 2025
Member
|
@stephane-pv would you like me to merge this now? I think you also have write access. |
Collaborator
Author
|
@cwhanse yes I can merge it, no problem. Just asked for the review to make sure you agree with the changes I suggested and made. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
combiner3dintocombiner_ac3dandcombiner_dc3dinstance_combiner3dintoinstance_combiner_ac3dandinstance_combiner_dc3dCloses #49