interface names can include non-word characters#1
Open
JensErat wants to merge 1 commit intopvcbe:masterfrom
Open
interface names can include non-word characters#1JensErat wants to merge 1 commit intopvcbe:masterfrom
JensErat wants to merge 1 commit intopvcbe:masterfrom
Conversation
Author
|
Maybe some remark; this will error out of the script for the first failed wireguard refresh (ie., DNS name not resolveable). This might be desired or not, and can surely be changed by adding some error handling. For me, the "error out" behavior was totally fine, because this way I realize the refresh and wireguard tunnel is broken by looking at the unit state. |
Interface names are not restricted to word characters. This discussions indicates pretty arbitrary characters are allowed, checking for non-space characters should be sufficient for this script. https://unix.stackexchange.com/q/451368/40798 Additionally, allows setting a different timeout and improves error handling ("bash strict mode") with required changes (default undeclared variables).
0426cdb to
12b1a4f
Compare
Owner
|
Hello Jens, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Interface names are not restricted to word characters. This discussions
indicates pretty arbitrary characters are allowed, checking for non-space
characters should be sufficient for this script.
https://unix.stackexchange.com/q/451368/40798
Additionally, allows setting a different timeout and improves error handling
("bash strict mode") with required changes (default undeclared variables).
If you prefer split commits/PRs, please drop a note or just pick whatever changes you agree to.