Added localized config support for Zone ID’s

[boboldehampsink]

Utilizes Craft's native ConfigHelper::localizedValue to add (static) config support for different zones for multisite systems

[bencroker]

Thanks for the PR! Multiple domain/zone support was requested in #73, and while this PR makes it possible via config settings only, that might be a good compromise. I’ll take a closer look in the coming days.

[boboldehampsink]

Cool! It would be so much better with an actual language switch available- but for now I focused on this "MVP"

[bencroker]

I looked a bit closer, and the PR currently requires a zone config setting, which is a breaking change.

Additionally, it feels like a half-baked solution, rather than a good compromise. Forcing users to use config settings, but not reflecting those settings in the CP feels wrong, and puts me back in the position I took in #73 (comment).

I appreciate the PR, but full multi-zone support is not on the roadmap for this plugin. You are of course welcome to continue using a forked version with your changes, if they solve your problem.

[boboldehampsink]

@bencroker zone is not required? We have a multisite setup running this fork where one site is behind cloudflare and one is not. Zone can be null.

And you should view this as a kind of advanced config. Localized config is a Craft native standard, not a half-baked solution imo.

[bencroker]

Your code currently requires a zone config setting to be defined.

[boboldehampsink]

@bencroker fixed that! Now it should not be a breaking change.

[bencroker]

Thanks, I’ve reopened this for discussion.