Conversation
zimbatm
force-pushed
the
connection-cleanup
branch
from
782f93c to
a7aea61
Compare
The Channel object doesn't have a `#disconnect` method in the first place !
This library is not thread-safe
zimbatm
force-pushed
the
connection-cleanup
branch
from
90852e6 to
4cbc3ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A couple of little things + the last commit who reworks how connection handling is done.
The a7aea61 commit makes things much better but is not there yet. This library is advertising the use of threads but is not thread-safe :/
EDIT: disabling async because it's horribly broken