This changes attachment behavior when the message contains poorly formatted content.#15
Open
manur wants to merge 2 commits intopurify:masterfrom
Open
This changes attachment behavior when the message contains poorly formatted content.#15manur wants to merge 2 commits intopurify:masterfrom
manur wants to merge 2 commits intopurify:masterfrom
Conversation
... when user-input message bodies have unresolvable URIs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When sending messages based on user content, some of the content can be incorrect -- including copy/pasted references to filesystem paths for images, for instance.
Rather than crash hard and fail delivery during URL resolution of an incorrectly formatted path, this change silently drops the incorrect URL silently. This is generally more robust behavior when the message body can contain poorly formatted text based on user entry.