Do not rely on legacy facts #121
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
commented
Jun 25, 2024
bastelfreak
commented
Jun 25, 2024
| hostname = networking[:hostname] | ||
| domain = networking[:domain] | ||
| if domain and domain != '' | ||
| fqdn = [hostname, domain].join('.') |
Author
There was a problem hiding this comment.
wouldn't it be easier to always use the networking.fqdn fact? I think when there's no domain, facter will set the fqdn to the hostname?
Contributor
There was a problem hiding this comment.
Im assuming this was copied from puppet https://github.com/puppetlabs/puppet/blob/7739378f6fa840d6dbee237132754c64f94cc38a/lib/puppet/settings.rb#L72
bastelfreak
changed the title
smortex
approved these changes
Jun 26, 2024
smortex
left a comment
smortex
left a comment
There was a problem hiding this comment.
Moving away of legacy facts seems a good move. As you say, this can probably use the networking.fqdn fact directly.
| hostname = networking[:hostname] | ||
| domain = networking[:domain] | ||
| if domain and domain != '' | ||
| fqdn = [hostname, domain].join('.') |
joshcooper
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.