[#46, #90] Upgrade Okhttp library to 3.6.0 and enable AOT#93
Open
jonathannaguin wants to merge 2 commits intopuniverse:masterfrom
Open
[#46, #90] Upgrade Okhttp library to 3.6.0 and enable AOT#93jonathannaguin wants to merge 2 commits intopuniverse:masterfrom
jonathannaguin wants to merge 2 commits intopuniverse:masterfrom
Conversation
jonathannaguin
commented
Apr 14, 2017
- Upgrade OkHttp to 3.6.0.
- Adding AOT for every project.
- Dropping support for retrofit, new version of retrofit (2.x) has renamed RestTemplate to Retrofit and now its Builder is final. However the builder supports a OkHttpClient as an option, so it might be possible to use comsat-okhttp client as a parameter to the builder.
added 2 commits
April 14, 2017 17:52
Dropping support for retrofit, new version of retrofit (2.x) has renamed RestTemplate to Retrofit and now its Builder is final. However the builder supports a OkHttpClient as an option, so it might be possible to use comsat-okhttp client as a parameter to the builder.
Author
|
@pron could anyone review this PR please? It seems some of the tests are failing but don't think it's related to my changes though |
Contributor
|
This is a very big PR. Thank you for taking the time to do it. But it does do quite a few separate things, and should probably be broken down.
|
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.