Added support for latest jOOQ version#91
Added support for latest jOOQ version#91roded wants to merge 1 commit intopuniverse:masterfrom roded:jooq
Conversation
|
Thank you! This looks good, but please change jooq-latest to jooq-java8 as you suggested. Also, take a look at the Quasar build file to see how to exclude subprojects from the build when built using Java 7. |
|
No problem. Could you be more explicit regarding the subproject build exclusion? |
|
On my machine, the exclusion of the tests from the sourceSet deletes the test class for some reason, not sure why.. |
|
@pron Could you review the gradle solution to make sure it's appropriate? |
circlespainter
left a comment
circlespainter
left a comment
There was a problem hiding this comment.
It's a very, very minor thing but as a convention I personally prefer having all the files ending with a newline, what do you think @pron?
comsat-jooq-java8/build.gradle
Outdated
| } | ||
|
|
||
| assemble.dependsOn jarTask | ||
| } No newline at end of file |
There was a problem hiding this comment.
I think the sources and javadoc jars are missing.
docs/index.md
Outdated
| {% include_snippet usage ./comsat-jooq/src/test/java/co/paralleluniverse/fibers/jooq/JooqContextTest.java %} | ||
| ~~~ | ||
|
|
||
| As with versions 3.7 and above, jOOQ requires Java 8, Comsat provides two separate jOOQ integrations: The legacy, Java 7 and below, `comsat-jooq` and `comsat-jooq-java8` which supports using jOOQ with Java 8. |
There was a problem hiding this comment.
I'd change it into:
Starting with versions 3.7 jOOQ requires Java 8 and Comsat provides two separate jOOQ integrations: comsat-jooq supports Java 6+ and jOOQ 3.6.x while comsat-jooq-java8 supports jOOQ 3.8.x with Java 8.
|
The sources & javadocs artifacts are inherited from the parent build.gradle it seems. Added them explicitly. |
|
The |
3 participants
Hi,
Here's a start.
I'm not sure about "comsat-jooq-latest", perhaps "comsat-jooq-java8" is more appropriate.
Please let me know of any comments or reservations.