Add -listen-address and -install-listen-address flags for macOS#322
Open
tcannonfodder wants to merge 4 commits intopuma:masterfrom
Open
Add -listen-address and -install-listen-address flags for macOS#322tcannonfodder wants to merge 4 commits intopuma:masterfrom
-listen-address and -install-listen-address flags for macOS#322tcannonfodder wants to merge 4 commits intopuma:masterfrom
Conversation
* In order to allow foreground instances of `puma-dev` on macOS to specify what addresses to listen to, there needs to be a command-line argument that can be used to specify what address the socket should listen on
* This allows users to customize how the service should be installed, defaulting to the current behavior of `0.0.0.0` for compatability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This could solve the issues outlined in #306, where users want to specify the addresses they listen to on
puma-dev.-listen-addressdefaults to127.0.0.1, and-install-listen-addressto keep existing behavior.NOTE: these do not have tests yet, this is my first attempts at working in Go, so it's a starting point and definitely needs reviewed