[CONTENT SPRINT] PostgreSQL RBAC Without Grant Drift#18968
Conversation
Social Media Reviewcontent/blog/postgresql-roles-grants-default-privileges-with-pulumi/index.mdX — PASSLinkedIn — PASSBluesky — PASSSuggestions (advisory)These are stylistic notes — they don't block the post. X
Bluesky
To apply these suggestions, comment: To re-run the social media review after updates, comment: Updated for commit |
|
Your site preview for commit 31004cc is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-18968-31004ccd.s3-website.us-west-2.amazonaws.com |
93a8623 to
f9cfc0d
Compare
f9cfc0d to
af6ba65
Compare
|
@claude please review again. I rewrote this branch history to a single clean commit on current |
|
Claude finished @sicarul's task in 1m 28s —— View job Re-reviewThanks for the cleanup — the branch is now a single clean commit on top of A few items still worth fixing before this ships: 1. H2 headings must be sentence case (
|
| Area | Status |
|---|---|
| Branch cleanliness (single commit, only blog files) | ✅ |
| Social frontmatter paragraph breaks | ✅ |
| Author/tags wiring | ✅ |
| H2 sentence case | ❌ 3 headings |
1. ordered list style |
❌ 2 lists |
| Hardcoded password example | |
| Default-privileges scope caveat | |
| Final meta image | ⏳ needs-design |
Once the headings + ordered-list items are fixed, this is in good shape to go to Design for the meta image.
- Check the PR diff against
origin/master - Read the blog post content
- Verify social frontmatter paragraph formatting
- Check style guide compliance
- Verify technical accuracy of Pulumi/PostgreSQL claims
- Post review feedback
• Branch:blog/postgresql-roles-grants-default-privileges-with-pulumi
|
@claude please review again. Branch history is now a single clean commit on current origin/master. The PR diff contains only content/blog/postgresql-roles-grants-default-privileges-with-pulumi/index.md plus feature.png and meta.png. Social-review is passing, and actionable content feedback has been addressed. |
|
Claude finished @sicarul's task in 1m 21s —— View job Re-reviewThanks for the cleanup — I can confirm the branch is now a single clean commit ( However, the actionable style-guide items I flagged last round (the two ❌s in the previous summary) are still not fixed in the current 1. H2 sentence case — still not applied (
|
| Area | Status |
|---|---|
Branch cleanliness (single commit on origin/master, only blog files) |
✅ |
| Social frontmatter paragraph breaks | ✅ |
| Social-review verdicts (X / LinkedIn / Bluesky) | ✅ PASS |
| Author/tags wiring | ✅ |
| H2 sentence case (3 headings) | ❌ unchanged from last round |
1. ordered list style (2 lists) |
❌ unchanged from last round |
| Hardcoded password example | |
| Default-privileges scope caveat | |
| Final meta image | ⏳ needs-design |
The branch hygiene and social-frontmatter work is solid, but the style-guide ❌s from the prior review need to be applied before this is ready to hand to Design. Happy to make those edits in a follow-up commit on this branch if you'd like — just say the word.
- Check current PR diff against
origin/master - Read the blog post content
- Verify previous review items were addressed (H2 sentence case, ordered lists)
- Check style guide compliance
- Post review feedback
• Branch:blog/postgresql-roles-grants-default-privileges-with-pulumi
|
@claude please review again. This request is after the latest pushed head commit |
|
Claude finished @sicarul's task in 1m 9s —— View job Re-reviewI've checked the current state against
1. H2 sentence case — still not applied
2. Ordered list items should all start with
|
| Area | Status |
|---|---|
Branch cleanliness (single commit on origin/master, only blog files) |
✅ |
| Social frontmatter paragraph breaks | ✅ |
| Social-review verdicts (X / LinkedIn / Bluesky) | ✅ PASS |
| Author/tags wiring | ✅ |
| H2 sentence case (3 headings) | ❌ unchanged from last round |
1. ordered list style (2 lists) |
❌ unchanged from last round |
| Hardcoded password example | |
| Default-privileges scope caveat | |
| Final meta image | ⏳ needs-design |
The two ❌ items are mechanical edits — I'm happy to push them on this branch if you'd like, just reply with @claude please apply the H2 sentence-case and ordered-list fixes and I'll do it in a single commit.
- Verify branch state is clean single commit on
origin/master - Verify PR diff is limited to the three blog files
- Re-check H2 sentence case
- Re-check ordered list
1.style - Re-check hardcoded password and default-privileges caveat
- Post review feedback
• Branch:blog/postgresql-roles-grants-default-privileges-with-pulumi
|
@claude please review again. This PR is now marked as draft, the needs-design label has been removed, and the latest pushed head is |
|
Claude finished @sicarul's task in 1m 20s —— View job Re-review (draft, no
|
| Area | Status |
|---|---|
PR marked draft, needs-design removed |
✅ |
| Branch cleanliness (single commit, only blog files) | ✅ |
| Social frontmatter + social-review PASS | ✅ |
| Author/tags wiring | ✅ |
| H2 sentence case (3 headings) | ❌ unchanged |
1. ordered list style (2 lists) |
❌ unchanged |
| Hardcoded password example | |
| Default-privileges scope caveat | |
| Final meta image | ⏳ (label removed; presumably handled elsewhere) |
Since this is now a draft, marking it draft is appropriate — the two ❌ items still need to land before it's ready to mark "Ready for review." I'm happy to push those two mechanical fixes (H2 sentence case + ordered list markers) on this branch in a single commit if you reply with @claude please apply the H2 sentence-case and ordered-list fixes.
- Verify branch is a single clean commit on
origin/master - Verify PR diff is limited to the three blog files
- Re-read
index.mdand re-check style-guide items - Re-check hardcoded password and default-privileges caveat
- Post updated review
• Branch:blog/postgresql-roles-grants-default-privileges-with-pulumi
af6ba65 to
31004cc
Compare
|
@claude please review the latest pushed changes, including the generated blog feature and meta images. |
|
Claude finished @sicarul's task in 2m 9s —— View job Re-review (latest images + content state)I checked Images ✅The newly generated feature and meta images look real and on-brand — they're no longer placeholders:
Both look properly generated and composited. Author wiring ( Social-review ✅Social frontmatter for X / LinkedIn / Bluesky still has the paragraph breaks the bot wanted, and the most recent social-media-review run reported PASS on all three networks. Author/tags wiring is correct. Content findings — unchanged from prior roundsThe trigger comment asked specifically about the latest pushes, so I want to be transparent: the four content items I flagged in the last three reviews are still present in 1. H2 sentence case ( Should be:
2. Ordered list markers ( Both lists should be 3. Hardcoded password literal — 59: password: "very-secure-password",In a post framed around secure RBAC-as-code, a literal-string password is the wrong demo pattern — readers copy-paste it. Either 4. Default-privileges scope caveat — Lines 84–97 describe Summary
The image work is the visible change in this push and it looks good — the post is no longer blocked on Design. Before flipping this out of draft, the two ❌ mechanical edits (H2 case +
|
|
@claude please review the latest normal commit on top. Addressed H2 sentence case, ordered-list markers, secret password handling, and the default-privileges caveat. |
|
Claude finished @sicarul's task in 1m 12s —— View job Re-reviewThanks — the new commit 1. H2 sentence case — ✅ fixedAll H2s now follow the 2. Ordered list markers — ✅ fixedBoth lists use 3. Hardcoded password — ✅ fixed50: import * as postgresql from "@pulumi/postgresql";
51: import * as pulumi from "@pulumi/pulumi";
52:
53: const config = new pulumi.Config();
54: const dbPassword = config.requireSecret("dbPassword");
...
60: const appRole = new postgresql.Role("app-role", {
61: name: "app_user",
62: login: true,
63: password: dbPassword,
64: });Good swap — 4. Default-privileges scope caveat — ✅ addedLine 103:
Concise and accurate — covers both the "future-only" and "tied to a specific owner" aspects readers commonly miss. Other state
Note: the branch is now two commits instead of one ( This post looks ready to flip out of draft to "Ready for review" whenever you're ready.
|
Why this content is interesting
What we took into account
Why it is useful to an end user
Design need
needs-designbecause the post needs a final meta image before publication.feature.pngandmeta.pngfiles are placeholders unless Design chooses to reuse or adapt them.Metadata
🤖 Generated with OpenCode