[CONTENT SPRINT] From CloudFormation to Pulumi Without a Rewrite#18966
[CONTENT SPRINT] From CloudFormation to Pulumi Without a Rewrite#18966sicarul wants to merge 2 commits into
Conversation
Social Media Reviewcontent/blog/cloudformation-to-pulumi-import-strategy/index.mdX — PASSLinkedIn — PASSBluesky — PASSSuggestions (advisory)These are stylistic notes — they don't block the post. X
Bluesky
Updated for commit |
Docs Review: PR #18966 - From CloudFormation to Pulumi Without a RewriteThanks for the post, @sicarul. A few significant issues need to be addressed before this can ship, including some material that almost certainly should not be in this PR at all. Blockers - files that should be removed from the PRThe PR scope appears to have leaked far beyond the blog post itself:
After cleanup, the only files that should remain in this PR are:
Technical accuracy issues in the post
The Writing and style notes
Frontmatter and publishing readiness
SummaryThe post itself is structurally sound and well-targeted, but the technical inaccuracies in Step 2 and the Step 4 workflow contradiction need correction before publication. Most urgently, please scrub the non-blog files from this PR - Mention me (@claude) if you would like another pass after updates. |
|
Your site preview for commit 48623ed is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-18966-48623eda.s3-website.us-west-2.amazonaws.com |
Lighthouse Performance ReportCommit: 0b08001 | Metric definitions
|
0b08001 to
db5e099
Compare
db5e099 to
26464da
Compare
|
@claude please review again. I rewrote this branch history to a single clean commit on current |
|
Claude finished @sicarul's task in 1m 57s —— View job Docs Review (re-review): PR #18966Thanks for the rebase, @sicarul. The PR is now in good shape on the scope/cleanup side — but the technical accuracy issues from the previous review are still in the post. I want to flag clearly that they apply specifically to this blog post, in case those were the ones you thought didn't apply. What's resolved ✅
What's still broken — please address before publishing ❌These are the same items from the prior review. I re-verified each against the in-repo CLI reference. 1.
|
|
@claude please review again. Branch history is now a single clean commit on current origin/master. The PR diff contains only content/blog/cloudformation-to-pulumi-import-strategy/index.md plus feature.png and meta.png. Social-review is passing, and actionable content feedback has been addressed. |
|
Claude finished @sicarul's task in 1m 43s —— View job Docs Review (re-review #2): PR #18966Thanks for the rebase, @sicarul. Confirming the scope cleanup is solid — PR diff against What's resolved ✅
What's still broken — same items as previous reviews ❌1.
|
|
@claude please review again. This request is after the latest pushed head commit |
|
Claude finished @sicarul's task in 1m 23s —— View job Docs Review (re-review #3): PR #18966I re-pulled commit What's resolved ✅
What's still broken ❌These are the same three items from the original review and both re-reviews. Re-verified against 1.
|
26464da to
76745d1
Compare
|
@claude please review again. This PR is now marked as draft, the needs-design label has been removed, and the latest pushed head is |
|
Claude finished @sicarul's task in 2m 18s —— View job Docs Review (re-review #4): PR #18966I re-pulled commit Status updates
What's resolved in
|
76745d1 to
48623ed
Compare
|
@claude please review the latest pushed changes, including the generated blog feature and meta images. |
|
Claude finished @sicarul's task in 1m 51s —— View job Docs Review (re-review #5): PR #18966Re-pulled commit What's resolved in this push ✅
What's still broken ❌These are the same two items from re-review #4. The body of 1. "append the resource definition" —
|
|
@claude please review the latest normal commit on top. Addressed the current pulumi-bot feedback items for this PR. |
|
@claude please retry the review. The previous review request appears to have failed or stalled due to GitHub rate limits. Please review the latest HEAD and confirm whether the prior feedback is addressed. |
Why this content is interesting
What we took into account
Why it is useful to an end user
Design need
needs-designbecause the post needs a final meta image before publication.feature.pngandmeta.pngfiles are placeholders unless Design chooses to reuse or adapt them.Metadata
🤖 Generated with OpenCode