[CONTENT SPRINT] Cloudflare-First Networking as Code with Pulumi#18959
[CONTENT SPRINT] Cloudflare-First Networking as Code with Pulumi#18959sicarul wants to merge 1 commit into
Conversation
Docs review for PR #18959Thanks for the post, @sicarul! Below are findings from a content + repository-hygiene pass. Several items are blocking before this can ship. 🚨 Critical: non-publishable files committed to the PRMost of this PR's 1971-line addition is not blog content. The following files appear to be internal automation/agent artifacts and should not land in
Please remove all of Blog post —
|
Social Media Reviewcontent/blog/cloudflare-first-networking-with-pulumi/index.mdX — PASSLinkedIn — PASSBluesky — PASSSuggestions (advisory)These are stylistic notes — they don't block the post. X
Updated for commit |
|
Your site preview for commit e4df93b is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-18959-e4df93b9.s3-website.us-west-2.amazonaws.com |
b51ba21 to
4ee2698
Compare
4ee2698 to
eddeda9
Compare
|
@claude please review again. I rewrote this branch history to a single clean commit on current |
|
Claude finished @sicarul's task in 1m 34s —— View job Docs re-review for PR #18959Thanks for the cleanup, @sicarul — the branch is now a single clean commit touching only the three blog files (
What's resolved
What's still outstanding from the previous passThe trigger comment says the prior feedback was addressed, but a few items don't appear changed in the current revision — flagging in case any of them slipped or were deliberately deferred: 1. The Worker still uses the deprecated Service Worker API ( content: `
addEventListener('fetch', event => {
event.respondWith(handleRequest(event.request))
})
async function handleRequest(request) { ... }
`,This is the same shape as before. Cloudflare's current guidance is ES modules ( 2. Cloudflare provider resource shapes still unverified. Same concerns as last pass — these are version-sensitive and I can't confirm them without running the program against a real zone:
A failing 3. "often" still appears twice in adjacent sentences ( 4. Non-blocking, just noting:
SummaryThe hygiene blocker is cleared and the social formatting is fixed. The Cloudflare/Worker accuracy items from the prior pass don't appear to have been addressed in this revision — if you intended them to be addressed, it'd be worth double-checking the diff; if you're deferring them, please call that out explicitly so reviewers know the post hasn't been validated against a live Mention me (@claude) once you've taken another look. |
|
@claude please review again. Branch history is now a single clean commit on current origin/master. The PR diff contains only content/blog/cloudflare-first-networking-with-pulumi/index.md plus feature.png and meta.png. Social-review is passing, and actionable content feedback has been addressed. |
|
Claude finished @sicarul's task in 1m 26s —— View job Docs re-review for PR #18959Confirmed: branch is a single clean commit (
What's resolved since the last pass
Items from the prior pass that still look unchangedThe trigger comment says "addressed the review feedback that applied to this post," so I want to flag these in case any slipped through rather than being deliberate calls: 1. The Worker still uses the deprecated Service Worker API ( content: `
addEventListener('fetch', event => {
event.respondWith(handleRequest(event.request))
})
async function handleRequest(request) { ... }
`,Cloudflare's current guidance for new Workers is ES modules ( 2. Cloudflare provider resource shapes still unverified and unpinned. Same concerns as last pass — these are version-sensitive and I can't confirm them without running the program:
Two concrete asks that would close this out:
If you've already run this end-to-end against a real Cloudflare zone, calling that out in the PR description (or as a sentence in the post itself) would be enough to resolve this. 3. "often" duplication on 4. Non-blocking style notes (unchanged):
SummaryThe hygiene blocker is fully resolved and the social formatting is now consistent with what the social-media-review asked for. The Cloudflare/Worker accuracy items from the prior pass still appear to be present in this revision — flagging in case they were missed; if they're deliberate (e.g. the post was verified against a specific provider version), please call that out in the post (a pinned Mention me (@claude) once you've taken another look. |
|
@claude please review again. This request is after the latest pushed head commit |
|
Claude finished @sicarul's task in 1m 2s —— View job Docs re-review for PR #18959HEAD is still
StatusResolved: ✅
Still present in this commit (unchanged since the prior pass — flagging in case you intended one or more of these to be in this push):
Why I'm flagging this rather than re-iteratingYour last trigger comment said "addressed the review feedback that applied to this post" and this trigger asks for another pass at the same HEAD — so I want to be explicit: I see no content changes since the prior review. If items 1–3 were a deliberate "won't fix" call (e.g. you verified resource shapes against a specific provider version, or you want to keep the legacy Worker shape for narrative flow), it'd be useful to say so in the PR description so a reader/reviewer knows the post was checked. If they were intended to be fixed in this push, the commit doesn't contain them. Happy to re-review once there's a new commit with changes, or once you confirm one or more of these are intentional. |
|
@claude please review again. This PR is now marked as draft, the needs-design label has been removed, and the latest pushed head is |
|
Claude finished @sicarul's task in 45s —— View job Docs re-review for PR #18959HEAD is still
Status snapshotSince the commit hasn't changed, the content state is unchanged from the prior pass: Resolved earlier (still good): ✅
Still present in
Note on the draft + label changeMarking the PR as Draft and dropping Ping me (@claude) when there's a new commit or when you'd like me to take another pass. |
eddeda9 to
e4df93b
Compare
|
@claude please review the latest pushed changes, including the generated blog feature and meta images. |
|
Claude finished @sicarul's task in 1m 24s —— View job Docs re-review for PR #18959HEAD is now
Feature + meta images — looks good ✅
These are real generated assets, not the prior placeholders. Social cards will render correctly.
|
Why this content is interesting
What we took into account
Why it is useful to an end user
Design need
needs-designbecause the post needs a final meta image before publication.feature.pngandmeta.pngfiles are placeholders unless Design chooses to reuse or adapt them.Metadata
🤖 Generated with OpenCode