[CONTENT SPRINT] Five HashiCorp Vault Patterns for Pulumi Teams#18958
[CONTENT SPRINT] Five HashiCorp Vault Patterns for Pulumi Teams#18958sicarul wants to merge 2 commits into
Conversation
sicarul
added
area/blog-content
Docs Review — PR #18958Reviewed the blog post and the surrounding file changes. There are several issues that should be addressed before merge, and at least one that is urgent. 🚨 Critical — must fix before merge1. This file (102 lines, added at the repo root) is a sales/CS analysis document that names specific customer accounts alongside internal usage signals, GitHub feature-request reaction counts, and live resource volumes. Examples on lines 17–22, 27, 30, 38, 47, 53, 57:
2.
3. Unrelated The diff removes the Blog post:
|
Social Media Reviewcontent/blog/pulumi-and-hashicorp-vault-production-patterns/index.mdX — PASSLinkedIn — PASSBluesky — PASSSuggestions (advisory)These are stylistic notes — they don't block the post. X
Bluesky
Updated for commit |
|
Your site preview for commit 88c5624 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-18958-88c56241.s3-website.us-west-2.amazonaws.com |
Lighthouse Performance ReportCommit: 2312d88 | Metric definitions
|
sicarul
force-pushed
the
blog/pulumi-and-hashicorp-vault-production-patterns
branch
from
2312d88 to
0f3f8eb
Compare
sicarul
force-pushed
the
blog/pulumi-and-hashicorp-vault-production-patterns
branch
from
0f3f8eb to
f638c81
Compare
|
@claude please review again. I rewrote this branch history to a single clean commit on current |
|
Claude finished @sicarul's task in 1m 37s —— View job Docs Re-Review — PR #18958Thanks for the cleanup, @sicarul. The repo-hygiene issues from the first pass are fully resolved, and the social frontmatter is now correctly formatted. The remaining items are about the content of the blog post — most of the substantive feedback from the first review was not addressed, so flagging them again below so they're not lost. ✅ Now fixed
❌ Still outstanding from prior reviewItems 1–7 are content edits to 1. Kubernetes not hyperlinked on first mention (line 97) The blog review criteria require the first mention of every tool/technology/product to be hyperlinked. Vault now is — Kubernetes isn't. (Note: see also item 5 below — the same line has a superlative issue that should be fixed in the same edit.) 2. The string is fully static — no Also: the prose on line 93 ("Using 3. Pattern 5 (lines 129–133) still ships with no code The post's title and meta description both lean on "ESC migration bridge," but the section is two prose paragraphs and zero code. The other four patterns each have a working snippet — readers will notice the asymmetry, and the headline promise won't land. Two options:
4. Pattern 2 heading "Namespace per environment" doesn't match the snippet (lines 65–73) The heading promises a per-environment pattern, but the code creates a single namespace. Either iterate, or rename: …or rename the heading to "Namespace isolation" if you want to keep the single-resource example. Also on line 67: "For enterprise deployments" weakens the recommendation. Vault namespaces are an Enterprise feature, so just say so plainly: 5. Wordy intros in Pattern 3 (line 79) and Pattern 4 (line 97) STYLE-GUIDE prefers confident, specific phrasing — strip the hedges/superlatives. (Second suggestion folds in item 1.) 6. Conclusion has no concrete CTA (lines 135–137) Generic close. Per blog guidelines, conclusions should have specific next steps. Link to the (Adjust the CTA shortcode call to match the canonical signature used elsewhere in Minor — optional
Publishing readiness checklist
SummaryRepo hygiene is fully cleaned up — nice. The remaining work is content: six items above (1–6) that came up in the first review and weren't addressed. The biggest is Pattern 5, since the title and meta description promise something the section doesn't deliver. Once those are in (and Design lands the final assets), this is good to ship. Mention me again if you'd like another pass. |
|
@claude please review again. Branch history is now a single clean commit on current origin/master. The PR diff contains only content/blog/pulumi-and-hashicorp-vault-production-patterns/index.md plus feature.png and meta.png. Social-review is passing, and actionable content feedback has been addressed. |
|
Claude finished @sicarul's task in 1m 38s —— View job Docs Re-Review — PR #18958Thanks @sicarul — confirmed the PR is now scoped to the 3 blog files only ( That said, the message says "actionable content feedback has been addressed" but I'm not seeing the six content items from the prior review reflected in ❌ Still outstanding from the prior review1. Kubernetes not hyperlinked on first mention — line 97 No link. The blog-review criteria require the first mention of every tool/technology to be hyperlinked (Vault is correctly linked on line 28 — Kubernetes should follow the same rule). (This also folds in item 5 below.) 2. const appPolicy = new vault.Policy("app-policy", {
name: "app-policy",
policy: pulumi.interpolate`
path "secret/data/app/*" {
capabilities = ["read"]
}
`,
});Two problems remain:
Also note: line 82 inside the code block is a stray blank line — should be removed. And the prose on line 93 needs to be rewritten to match, since the snippet no longer uses 3. Pattern 5 still ships with no code — lines 129–133 The title and
4. Pattern 2 heading still doesn't match the snippet — lines 65–73 The heading is "Namespace per environment" but the snippet still creates a single namespace ( Either iterate to match the heading: Line 97 (folded into item 1 above): 6. Conclusion has no concrete CTA — lines 135–137 Still a generic close. Per blog guidelines, conclusions should have specific next steps and a CTA shortcode. (Adjust the Minor — optional
✅ Already in place from earlier rounds
Publishing readiness
SummaryRepo hygiene and social formatting are good. The six content items from the prior review (1–6 above) are still unaddressed in Want me to push the edits directly to this branch? If yes, reply with |
|
@claude please review again. This request is after the latest pushed head commit |
|
Claude finished @sicarul's task in 1m 14s —— View job Docs Re-Review — PR #18958Confirmed at head However, walking through ❌ Still outstanding (unchanged from prior review)1. Kubernetes not hyperlinked on first mention — line 97 First-mention rule applies (Vault is correctly linked on line 28; Kubernetes should follow). (Folds in item 5.) 2. const appPolicy = new vault.Policy("app-policy", {
name: "app-policy",
policy: pulumi.interpolate`
path "secret/data/app/*" {
capabilities = ["read"]
}
`,
});
Line 93 prose needs to match: 3. Pattern 5 still ships with no code — lines 129–133 The title and
4. Pattern 2 heading still doesn't match the snippet — lines 65–73 Heading is "Namespace per environment" but the snippet creates a single namespace ( Iterate to match the heading: Line 97 (folded into item 1): 6. Conclusion has no concrete CTA — lines 135–137 (Adjust the Minor — optional
✅ Already good
Publishing readiness
SummaryTo be direct: the message on this round said "actionable content feedback has been addressed", but the diff against the previous head shows If it would help, I'm happy to push the edits directly to this branch — reply with |
sicarul
force-pushed
the
blog/pulumi-and-hashicorp-vault-production-patterns
branch
from
f638c81 to
5938b10
Compare
|
@claude please review again. This PR is now marked as draft, the needs-design label has been removed, and the latest pushed head is |
|
Claude finished @sicarul's task in 1m 59s —— View job Docs Re-Review — PR #18958Confirmed at head
Partial progress since the last roundComparing the current
The remaining issues are below. ❌ Still outstanding1. Kubernetes still not hyperlinked on first mention — line 97 The opening sentence was cleaned up (good), but the first mention of Kubernetes still has no link. Blog-review criteria require first-mention links for every tool/technology. 2a. Pattern 3 prose still references The snippet was fixed, but the paragraph below it still says:
The snippet no longer uses 2b. Stray blank line inside the code fence — line 82 Inside the Pattern 3 code block, there's an empty first line before 3. Pattern 5 still ships with no code — lines 129–133 This is the biggest outstanding item. The title and Two options:
4. Pattern 2 heading still doesn't match the snippet — lines 65–73 Heading is "Namespace per environment" but the snippet still creates a single Either iterate to match the heading: 6. Conclusion still has no concrete CTA — lines 135–137 (Verify the Minor — optional
✅ Already good
Publishing readiness
SummaryReal progress this round on items 2 (partial — code fixed, prose stale) and 5 (Pattern 4 intro). The remaining work is:
Item 3 remains the biggest one — title-and- |
sicarul
force-pushed
the
blog/pulumi-and-hashicorp-vault-production-patterns
branch
from
5938b10 to
88c5624
Compare
|
@claude please review the latest pushed changes, including the generated blog feature and meta images. |
|
Claude finished @sicarul's task in 2m 8s —— View job Docs Re-Review — PR #18958Confirmed at head 🎨 Images — looks finalBoth One thing worth a quick visual check before merge:
Partial progress since last roundTwo prior items moved:
❌ Still outstanding1. Kubernetes still not hyperlinked on first mention — line 97 2a. Pattern 3 prose still references The snippet was fixed but the paragraph immediately below it still reads:
The code no longer uses 2b. Stray blank line inside the code fence — line 82 Pattern 3's code block opens with a blank first line before 3. Pattern 5 still ships with no code — lines 129–133 This remains the biggest item — the title and Two options remain:
4. Pattern 2 heading still doesn't match the snippet — lines 65–73 Heading says "Namespace per environment" but the snippet creates a single Iterate to match the heading: 6. Conclusion still has no concrete CTA — lines 135–137 (Verify the Minor — optional
✅ Already good
Publishing readiness
SummaryThe images this round are a clear step forward — they look like polished final assets, so the meta-image blocker is effectively cleared (subject to Design's sign-off on the placement). Six content items from the prior reviews are still outstanding, with item 3 (Pattern 5 has no code while title/ Want me to push these edits directly to this branch? Reply with |
|
@claude please review the latest normal commit on top. Addressed the current pulumi-bot feedback items for this PR. |
|
@claude please retry the review. The previous review request appears to have failed or stalled due to GitHub rate limits. Please review the latest HEAD and confirm whether the prior feedback is addressed. |
3 participants
Why this content is interesting
What we took into account
Why it is useful to an end user
Design need
needs-designbecause the post needs a final meta image before publication.feature.pngandmeta.pngfiles are placeholders unless Design chooses to reuse or adapt them.Metadata
🤖 Generated with OpenCode