[CONTENT SPRINT] One ESC Environment, Many Secret Stores#18957
Conversation
Social Media Reviewcontent/blog/multi-source-secrets-with-pulumi-esc/index.mdX — PASSLinkedIn — PASSBluesky — PASSSuggestions (advisory)These are stylistic notes — they don't block the post. X
Bluesky
Updated for commit |
|
test body |
|
short test body |
|
Docs review for PR 18957 Reviewing as a CI agent. Two distinct problems: a sizable stack of unrelated agent artifacts that shouldn`t ship in this PR, and some style/structure issues in the blog post itself. Out-of-scope files (blocker) This PR is titled "One ESC Environment, Many Secret Stores" but ~95% of the diff has nothing to do with that post. Please drop the following before merging — they look like local Sisyphus/agent planning artifacts and a raw research dump that escaped a
If you want to keep this scaffolding locally, the plan Blog post: 1. Placeholder meta and feature images (blocker). 2. Duplicate content across the more-break. Line 25 opens "The pain of secret sprawl" with "As organizations grow, secrets naturally scatter across different platforms." Line 39 then opens "The Challenge of Secret Sprawl" with the same sentence verbatim and re-covers identical material as a list. Pick one — the list version on line 39–44 is tighter; the prose version on line 25 can be cut entirely. The intro on line 19–21 is sufficient hook on its own. 3. More-tag placement is too deep (line 35). The criteria call for the break after 1–3 paragraphs. Right now four sections (intro, 4. H2 heading case (STYLE-GUIDE.md — H2+ is sentence case). Four headings are Title Case and should be lowercased to sentence case:
The first three H2s (lines 23, 27, 31) are correctly sentence-cased — these four are the outliers. 5. Missing first-mention links. Per blog criteria, every tool/product gets hyperlinked on first mention. None of these are linked anywhere in the post:
6. Weak ending; no CTA shortcode. Line 122 wraps with a generic summary. Feature/integration posts should land with a concrete next step using the 7. Vault snippet worth confirming. Line 79–82 reads 8. ESC YAML otherwise checks out. I cross-referenced the 9. Minor AI/hedging language. A few phrases lean generic — "naturally scatter", "best-of-breed", "improve your security posture". Easy to tighten in a pass after the structural changes above. Publishing readiness checklist
@claude — mention me on this PR if you would like another pass after these changes, or want me to look at anything specific. |
|
Your site preview for commit 039cb9d is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-18957-039cb9d4.s3-website.us-west-2.amazonaws.com |
741ef13 to
f8de735
Compare
f8de735 to
f1a46b1
Compare
|
@claude please review again. I rewrote this branch history to a single clean commit on current |
|
Claude finished @sicarul's task in 2m 12s —— View job Re-review for PR 18957 (commit
|
|
@claude please review again. Branch history is now a single clean commit on current origin/master. The PR diff contains only content/blog/multi-source-secrets-with-pulumi-esc/index.md plus feature.png and meta.png. Social-review is passing, and actionable content feedback has been addressed. |
|
Claude finished @sicarul's task in 1m 20s —— View job Re-review for PR 18957 (commit
|
|
@claude please review again. This request is after the latest pushed head commit |
|
Claude finished @sicarul's task in 2m 13s —— View job Re-review for PR 18957 (commit
|
|
@claude please review again. This PR is now marked as draft, the needs-design label has been removed, and the latest pushed head is |
|
Claude finished @sicarul's task in 1m 7s —— View job Re-review for PR 18957 (commit
|
f1a46b1 to
23518a9
Compare
|
@claude please review the latest pushed changes. |
|
Claude finished @sicarul's task in 1m 28s —— View job Re-review for PR 18957 (commit
|
23518a9 to
039cb9d
Compare
|
@claude please review the latest pushed changes, including the generated blog feature and meta images. |
|
Claude finished @sicarul's task in 1m 52s —— View job Re-review for PR 18957 (commit
|
|
@claude please review the latest normal commit on top. Addressed the current pulumi-bot feedback items for this PR. |
|
@claude please retry the review. The previous review request appears to have failed or stalled due to GitHub rate limits. Please review the latest HEAD and confirm whether the prior feedback is addressed. |
Why this content is interesting
What we took into account
Why it is useful to an end user
Design need
needs-designbecause the post needs a final meta image before publication.feature.pngandmeta.pngfiles are placeholders unless Design chooses to reuse or adapt them.Metadata
🤖 Generated with OpenCode