[CONTENT SPRINT] Wire Datadog, New Relic, and PagerDuty with Pulumi#18956
[CONTENT SPRINT] Wire Datadog, New Relic, and PagerDuty with Pulumi#18956sicarul wants to merge 1 commit into
Conversation
Social Media Reviewcontent/blog/wiring-observability-stack-with-pulumi/index.mdX — PASSLinkedIn — PASSBluesky — PASSSuggestions (advisory)These are stylistic notes — they don't block the post. X
Updated for commit |
Docs review for #18956Thanks for the new content sprint post! Below are the issues I found, grouped by severity. Blocking issues1. H2 headings should use sentence case (STYLE-GUIDE.md, AGENTS.md) H1 is Title Case; H2+ are sentence case.
(I would also recommend removing the link from inside the heading at line 32 — it is already linked in the first sentence of the body at line 34, and links in headings make anchor generation awkward.) 2. Ordered list items should all start with The repo convention is "Every item begins with
3. Bug in code example: Output interpolated into template literal (line 80)
Side note: in Datadog PagerDuty integration, the 4. Missing blank line between paragraphs (lines 127-128) These two sentences run together with no blank line, so they render as a single paragraph: Insert a blank line between line 127 and line 128. Suggested improvements5. Content/code mismatch around escalation policies and tagging The "What you will build" list (line 25) promises "PagerDuty services and escalation policies", but the code only references an existing escalation policy by ID ( Likewise, the post highlights "unified tagging across all three providers" (line 28), but only the Datadog monitor at line 81 actually sets tags. Consider adding equivalent tag arguments on the PagerDuty service and New Relic alert policy/condition so the example matches the promise. 6. Deprecated New Relic resources
7. First-mention links missing Per the blog review criteria, first mention of each tool/product should be hyperlinked.
8. Conclusion is generic; CTA is missing The closing two sentences (line 134) — "Pulumi provides the scale and flexibility needed for modern operations" — are vague filler. The blog review criteria call for "specific next steps (not vague check out Pulumi)." Consider linking to the Datadog/New Relic/PagerDuty provider docs or a relevant Pulumi ESC guide, and using the 9. Minor AI-pattern / phrasing issues
Frontmatter / publishing readiness
Out-of-scope changeThe diff removes a If you would like another pass after addressing these, mention me (@claude) and I will re-review. |
|
Your site preview for commit 3b376a2 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-18956-3b376a2a.s3-website.us-west-2.amazonaws.com |
Lighthouse Performance ReportCommit: b7edd45 | Metric definitions
|
b7edd45 to
e06f75c
Compare
e06f75c to
51fd6c3
Compare
|
@claude please review again. I rewrote this branch history to a single clean commit on current |
|
Claude finished @sicarul's task in 1m 24s —— View job Re-review for #18956Thanks for the cleanup, @sicarul — the branch is now a single commit on Fixed since last review
Still blocking1. H2 headings — sentence case (and link in heading) Per AGENTS.md, H2+ are sentence case. Two H2s are still Title Case, and one still has a link inside it:
The link to 2. Ordered list items should all start with AGENTS.md: "Every item begins with
3. Missing blank line between paragraphs (lines 136-137) Same issue as before, now at lines 136-137. The two sentences render as one paragraph because there is no blank line: Insert a blank line between line 136 and line 137. Still open from "suggested improvements"These were marked as suggestions last time, not blockers — flagging again in case you want to address before publish:
Frontmatter / publishing readiness
SummaryPR scope is now correct, social copy is fixed, and the worst code bug (Output-in-template-literal) is resolved. The three remaining blocking items are mechanical style rules (heading case, ordered-list |
|
@claude please review again. Branch history is now a single clean commit on current origin/master. The PR diff contains only content/blog/wiring-observability-stack-with-pulumi/index.md plus feature.png and meta.png. Social-review is passing, and actionable content feedback has been addressed. |
|
Claude finished @sicarul's task in 1m 12s —— View job Re-review for #18956Thanks @sicarul. The PR scope is correct (3 files: Still blocking1. H2 headings must be sentence case (AGENTS.md, "Headings") H1 is Title Case; H2+ are sentence case. Two H2s are still Title Case, and one still has a link inside it.
The link to 2. Ordered list items must all start with
Both ordered lists still use
3. Missing blank line between paragraphs (lines 136-137) The two sentences still render as one paragraph because there is no blank line between them: Insert a blank line between line 136 and line 137. Confirmed fixed since last review
Still open (non-blocking, flagged for completeness)These were "suggested improvements" last time, not blockers — listing again so they aren't lost:
Frontmatter / publishing readiness
SummaryThe branch hygiene and social work are done. The remaining three blockers are mechanical style rules (H2 sentence case ×2, ordered-list
|
|
@claude please review again. This request is after the latest pushed head commit |
|
Claude finished @sicarul's task in 1m 9s —— View job Re-review for #18956Thanks @sicarul. Confirmed the branch hygiene: single commit on top of However, the same three mechanical style blockers from my last review are still present at Still blocking1. H2 headings must be sentence case (AGENTS.md, "Headings") H1 is Title Case; H2+ are sentence case. Two H2s are still Title Case, and one still has a link inside it.
The link to 2. Ordered list items must all start with
Both ordered lists still use
3. Missing blank line between paragraphs (lines 136-137) The two sentences still render as one paragraph because there is no blank line between them: Insert a blank line between line 136 and line 137.
Confirmed still good
Still open (non-blocking, flagged for completeness)These were "suggested improvements" — not blockers, but listing again so they aren't lost:
Frontmatter / publishing readiness
SummaryPR scope, branch hygiene, social copy, and the
|
|
@claude please review again. This PR is now marked as draft, the needs-design label has been removed, and the latest pushed head is |
|
Claude finished @sicarul's task in 56s —— View job Re-review for #18956Thanks @sicarul. Acknowledged: PR is now draft and the However, the file content at Still blocking1. H2 sentence case (AGENTS.md, "Headings")
Should be: 2. Ordered list items must all start with
3. Missing blank line between paragraphs
Still confirmed good
Non-blocking, flagged for completenessUnchanged from last review — listing the labels only, see prior comment for detail:
Frontmatter / publishing readiness
SummaryPR scope, branch hygiene, social copy, and the
|
51fd6c3 to
3b376a2
Compare
|
@claude please review the latest pushed changes, including the generated blog feature and meta images. |
|
Claude finished @sicarul's task in 1m 53s —— View job Re-review for #18956Thanks @sicarul — reviewed the latest pushed changes (HEAD The good news: image dimensions are right and New blocking issue — image content does not match the postBoth
The post is titled "Wire Datadog, New Relic, and PagerDuty with Pulumi" and Prometheus is not mentioned anywhere in the body. The feature/meta imagery therefore misrepresents the content. Either the images need to be regenerated with the New Relic and PagerDuty logos, or the post needs to be rewritten around Datadog/Prometheus/Pulumi — but the first option is clearly what's intended given the title, frontmatter, and code samples. For reference: New Relic's mark is a green "NR" badge; PagerDuty's mark is a green/circle "PD" with a notch. The current bottom-right flame is Prometheus's torch. Still blocking (mechanical style — unchanged at HEAD)1. H2 headings must be sentence case (AGENTS.md, "Headings")
The link to 2. Ordered list items must all start with
3. Missing blank line between paragraphs (lines 136-137) The two sentences still run together with no blank line, so they render as one paragraph: Fix all three style blockers →
Confirmed still good
Still open (non-blocking)Unchanged from previous reviews — listing labels only:
Frontmatter / publishing readiness
SummaryThe biggest finding this round is the image content mismatch — the feature/meta images show Datadog, Pulumi, and Prometheus, but the post is about Datadog, New Relic, and PagerDuty. That's a publish-blocker since the OG image and social preview will mislead readers. The three mechanical style blockers from prior reviews are still present and unchanged. Happy to push the three style fixes on request; the image regeneration is best done by re-running the |
Why this content is interesting
What we took into account
Why it is useful to an end user
Design need
needs-designbecause the post needs a final meta image before publication.feature.pngandmeta.pngfiles are placeholders unless Design chooses to reuse or adapt them.Metadata
🤖 Generated with OpenCode